criu: fix error release #1934
criu: fix error release #1934
Conversation
Summary of ChangesHello @eriksjolund, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a subtle but important error handling issue within the CRIU checkpointing functionality. It modifies the code to explicitly release an error object when a directory check fails, thereby preventing resource leaks and ensuring that the error state is properly managed. This change enhances the stability and reliability of the container checkpointing process. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request addresses a memory leak in error handling within libcrun_container_checkpoint_linux_criu. When crun_dir_p_at failed, it would allocate an error object that was subsequently leaked because crun_make_error was called again, overwriting the error pointer. Your change correctly fixes this by releasing the previously allocated error. However, this approach loses the original, more specific error message. I've provided a suggestion to use crun_error_wrap instead, which preserves the valuable context from the original error, leading to better diagnostics, while still resolving the memory leak.
|
TMT tests failed. @containers/packit-build please check. |
Suggestion by gemini-code-assist in containers#1934 was amended. Signed-off-by: Erik Sjölund <[email protected]>
eriksjolund
force-pushed
the
criu-error-release
branch
from
4090eff to
2690032
Compare
2 participants
No description provided.